script tag with | character ( version 0.26.3 ) #782

Closed
ghost opened this Issue Oct 4, 2012 · 2 comments

Comments

Projects
None yet
2 participants

ghost commented Oct 4, 2012

sry if this is a shitty bug report it is on the fly

this throws an error in the browser it carries over the |

script  
  |(function(d, s, id) {
  |  var js, fjs = d.getElementsByTagName(s)[0];
  |  if (d.getElementById(id)) return;
  |  js = d.createElement(s); js.id = id;
  |  js.src = "//connect.facebook.net/en_US/all.js#xfbml=1";
  |  fjs.parentNode.insertBefore(js, fjs);
  | }(document, 'script', 'facebook-jssdk'));

this does not
p
|(function(d, s, id) {
| var js, fjs = d.getElementsByTagName(s)[0];
| if (d.getElementById(id)) return;
| js = d.createElement(s); js.id = id;
| js.src = "//connect.facebook.net/en_US/all.js#xfbml=1";
| fjs.parentNode.insertBefore(js, fjs);
| }(document, 'script', 'facebook-jssdk'));

@caseywebdev

This comment has been minimized.

Show comment Hide comment
@caseywebdev

caseywebdev Oct 4, 2012

Contributor

You don't need a pipe (|) for the script tag. It is special-cased. Just use

script
  var this = 'my code';
Contributor

caseywebdev commented Oct 4, 2012

You don't need a pipe (|) for the script tag. It is special-cased. Just use

script
  var this = 'my code';

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Oct 4, 2012

Thank you!

Sorry.

On Thu, Oct 4, 2012 at 4:12 PM, Casey Foster notifications@github.comwrote:

You don't need a pipe (|) for the script tag. It is special-cased. Just
use

script
var this = 'my code';


Reply to this email directly or view it on GitHubhttps://github.com/visionmedia/jade/issues/782#issuecomment-9155408.

ghost commented Oct 4, 2012

Thank you!

Sorry.

On Thu, Oct 4, 2012 at 4:12 PM, Casey Foster notifications@github.comwrote:

You don't need a pipe (|) for the script tag. It is special-cased. Just
use

script
var this = 'my code';


Reply to this email directly or view it on GitHubhttps://github.com/visionmedia/jade/issues/782#issuecomment-9155408.

@tj tj closed this Oct 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment