Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

What are AST Filters? #790

Closed
slang800 opened this Issue Oct 21, 2012 · 2 comments

Comments

Projects
None yet
3 participants
Contributor

slang800 commented Oct 21, 2012

The readme mentions them under the features section, but it doesn't tell what they do. Also, there is an example file and there is a function in the parser:

  parseASTFilter: function(){
    var block
      , tok = this.expect('tag')
      , attrs = this.accept('attrs');

    this.expect(':');
    block = this.block();

    var node = new nodes.Filter(tok.val, block, attrs && attrs.attrs);
    node.line = this.line();
    return node;
  },

... However, #155 (from 2 years ago) says this should be deprecated. So are AST filters still a supported feature, and if so, what do they do? Or is this just leftover code that should be removed?

Edit: Also, there aren't any tests that cover this feature (removing the above code from the parser still passes all tests)

Contributor

tj commented Oct 22, 2012

i wouldn't mind removing them, it's not trivial to implement the ast filters and they're prone to breakage as our internal representations change

@tj tj closed this in 8376e06 Nov 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment