Caching and caching tests improvements #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is already covered by some other tests, but not directly, resulting in an uncovered branch. Places already covering this function: 1. Deprecation test for `options.client` (under-the-hood) 2. All the test cases
|
I'll merge this in two days if no one reviews, to keep PRs from rotting. |
|
If we did, function handleFileCache (options) {
if (options.cache && exports.cache[options.filename]) {
return exports.cache[options.filename];
} else {
var result = exports.compile(fs.readFileSync(options.filename, 'utf8'), options);
if (options.cache) exports.cache[options.filename] = result;
return result;
}
}We could skip the extra (totally pointless) cache of the source strings. |
|
(2nd if's condition should read |
|
Thanks, updated |
|
IIRC I tried that but it didn't work for some obscure reason I do not recall right now. Will get back to you. |
|
Updated PR. Removed handleSrcCache() altogether. |
| ? exports.cache[key] || (exports.cache[key] = fs.readFileSync(path, 'utf8')) | ||
| : fs.readFileSync(path, 'utf8'); | ||
| return exports.render(str, options); | ||
| return exports.render(null, options); |
There was a problem hiding this comment.
Maybe it would be better if this did:
return handleTemplateCache(options)(options);It's not much duplicated code, and it keeps exports.render from needing to accept null for the string. We could then add a check in exports.render that throws if str === null to catch that odd corner case. I'd hate to end up having to support it forever.
TimothyGu
force-pushed
the
caching-test
branch
from
b2fc998
to
781901a
Compare
ForbesLindesay
added a commit
that referenced
this pull request
Jan 13, 2015
Caching and caching tests improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.