Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update with #3259

Merged
merged 1 commit into from May 25, 2020
Merged

chore: update with #3259

merged 1 commit into from May 25, 2020

Conversation

@ForbesLindesay
Copy link
Member

@ForbesLindesay ForbesLindesay commented May 25, 2020

closes #3239

@rollingversions
Copy link

@rollingversions rollingversions bot commented May 25, 2020

pug-code-gen (3.0.0 → 3.0.1)

Bug Fixes

  • Update with to resolve core-js deprecation notice

Packages With No Changes

The following packages have no user facing changes, so won't be released:

  • pug
  • pug-attrs
  • pug-error
  • pug-filters
  • pug-lexer
  • pug-linker
  • pug-load
  • pug-parser
  • pug-runtime
  • pug-strip-comments
  • pug-walk

Edit changelogs

@ForbesLindesay ForbesLindesay merged commit 13e46e9 into master May 25, 2020
4 checks passed
4 checks passed
@github-actions
test (10.x)
Details
@github-actions
test (12.x)
Details
@github-actions
test (14.x)
Details
@rollingversions
RollingVersions releasing pug-code-gen
Details
@ForbesLindesay ForbesLindesay deleted the chore/update-with branch May 25, 2020
@IanVS
Copy link

@IanVS IanVS commented Jul 30, 2020

I believe this should have been a breaking change, since with@7 no longer supports node 8, which emans that pug-code-gen also stopped supporting node 8 starting in version 3.0.1. I believe the right thing to do is to revert this change, and release a 4.0.0 version with this update to with.

This was referenced Mar 7, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants