Improve performance of pretty mixins #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent addition of pretty mixins degraded performance noticably for options like "compileDebug: false" or "self: true". Now we only adjust the compiled jade where mixins are actually being called. The performance when no mixins are present is now comparable to before.
|
I apologize, I should not have submitted the last pull request before more performance testing. This new version is much better. |
|
Performance is approx 2x better for "compileDebug: false" option over my last pull request. |
tj
added a commit
that referenced
this pull request
Apr 15, 2012
Improve performance of pretty mixins
|
we could definitely use some more benchmraks in the repo, mine are too small and dont use the options |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent addition of pretty mixins degraded performance noticably for options like "compileDebug: false" or "self: true".
Now we only adjust the compiled jade where mixins are actually being called.
The performance when no mixins are present is now comparable to before. The performance has also improved when mixins are being called. This also works for pretty nested mixins.