Strip UTF-8 BOMs off of strings passed to jade.compile. #702

Merged
merged 1 commit into from Jul 9, 2012

Conversation

Projects
None yet
2 participants
Contributor

domenic commented Jul 9, 2012

Sometimes, people are dumb, and files get generated with UTF-8 BOMs at the end. Jade can help those dumb people.

If you don't want to accept this that's fine, and we can just tell people to strip it off themselves. It's not as big a deal here as it is elsewhere since you pass Jade a string, not a filename, so if you leave the BOM in it's your fault, not Jade's.

@domenic domenic Strip UTF-8 BOMs off of strings passed to jade.compile.
Sometimes, people are dumb, and files get generated with UTF-8 BOMs at the end. Jade can help those dumb people.
87d9f4d

tj merged commit 4efd475 into pugjs:master Jul 9, 2012

Contributor

tj commented Jul 9, 2012

i do think something like this belongs higher up in a node API or similar but meh! fine for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment