Fix rethrow in browser #756

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@ixti
Contributor
ixti commented Aug 30, 2012

These patches surrounds node-specific part of context builder in runtime.rethrow
with // if node ... // end comments. Also they improve browserified runtime
compilation with support/compile_runtime.js hich respects conditional comments.

ixti added some commits Aug 30, 2012
@ixti ixti Make runtime.rethrow more browser-friendly
This patch removes `fs`-dependent logic of error context building out of
browserified version of runtime.
0626522
@ixti ixti Refactor browserified runtime compilation cf6eb69
@ixti
Contributor
ixti commented Aug 30, 2012

Sorry. My problem was not related to the fix I provided :))

@ixti ixti closed this Aug 30, 2012
@ixti
Contributor
ixti commented Aug 30, 2012

In fact this fix does not makes any sense (as I just figured out).
But it removes potentionally problematic place in browserified version.

I'm reopening pull-request, but feel free to close it, if you don't need/like it :))

@ixti ixti reopened this Aug 30, 2012
@ForbesLindesay
Member

Closing in favor of #985

@ixti ixti deleted the unknown repository branch Apr 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment