move filters to an external library #860

Merged
merged 1 commit into from Mar 30, 2013

Projects

None yet

3 participants

Owner

Rebase of #857

This makes filters just use an external library. It uses transformers which supports all the same filters as jade so there's no loss of functionality. There are loads of additional filters that are then supported, which I think is really useful.

We could move transformers and coffee-script into devDependencies and let people install them only if needed?

P.S.transformers works like consolidate.js and does not install the dependencies itself, but lets you install the ones you need.

Contributor

+1 this looks like a great idea... as soon as it has full test coverage, it'll be perfect.

Owner

It has pretty full test coverage on account of replacing the filters already in place for coffee-script/markdown etc.

It doesn't make sense to have test coverage for every single possible filter, since those are all tested in more depth in transformers.

Contributor

Oh, sorry, I thought that this introduced those new features you described in #853, so the fact that no tests had been added led me to assume that this feature didn't have full test coverage. Anyway, I agree that tests aren't needed for every type of filter, but once features like chaining filters are added then there will need to be additional tests.

hope this will be merged soon

@ForbesLindesay ForbesLindesay referenced this pull request Mar 19, 2013
Closed

Sass/SCSS filter? #932

@ForbesLindesay ForbesLindesay merged commit 365c255 into pugjs:master Mar 30, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment