Blog name text / theme mod #134

Open
justintadlock opened this Issue Jan 11, 2017 · 0 comments

Projects

None yet

1 participant

@justintadlock
justintadlock commented Jan 11, 2017 edited

This line is a bit odd in inc/extras.php (line 651). It's one of those things that will technically work, so not immediately apparent that it's a bug.

_e( ( get_theme_mod( 'blog_name' ) ) ? get_theme_mod( 'blog_name' ) : 'Blog', 'shapely' );

It should be something like this:

echo esc_html( get_theme_mod( 'blog_name' ) ? get_theme_mod( 'blog_name' ) : __( 'Blog', 'shapely' ) );

_e() shouldn't wrap the entire thing because translation parsers can only pick up strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment