Resource will be a reserved keyword #119
Comments
It does not seem to be a problem: https://travis-ci.org/puli/repository/jobs/80213636. Is it something not yet present in the PHP7 nightly of Travis? |
I didn't investigate yet. Could it be a big BC? |
It is definitely a problem for StyleCI, but we can disable the phpdoc_types fixer to ignore it. Would it be fine for you @webmozart ? |
Yes, let's do that for now. |
Given that renaming it in Puli is a BC break, it would be better to do it before reaching 1.0 instead of facing the need for a BC break later on if PHP actually makes use of it as a reserved keyword. |
Any suggestion for a good name? |
|
@webmozart I can't think of a better suggestion |
Well we still have |
On a serious side, let's go for |
@webmozart sure, I can do it |
This fix needs to be applied to all repositories: |
@EmanueleMinotto Will you have time to fix the other repositories soon? Currently, most repositories are broken on master. |
This is finished now. :) |
Quoting Style CI:
Ref: https://twitter.com/TeamStyleCI/status/645906122524753920 & https://wiki.php.net/rfc/reserve_even_more_types_in_php_7
This could be a problem for
Puli\Repository\Api\Resource\Resource
, should it be renamed?The text was updated successfully, but these errors were encountered: