From d3cd4adc6c3a0c20af7764ed9d37c6655fb83f7c Mon Sep 17 00:00:00 2001
From: Trey Pendragon <tpendragon@princeton.edu>
Date: Thu, 8 Mar 2018 14:12:56 -0800
Subject: [PATCH] Fix coverage.

---
 .../manifest_builder/start_canvas_builder.rb         |  4 ----
 spec/services/manifest_builder_spec.rb               | 12 +++++++++++-
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/app/services/manifest_builder/start_canvas_builder.rb b/app/services/manifest_builder/start_canvas_builder.rb
index a4b93ad1a2..693b39c125 100644
--- a/app/services/manifest_builder/start_canvas_builder.rb
+++ b/app/services/manifest_builder/start_canvas_builder.rb
@@ -17,10 +17,6 @@ def apply(manifest)
 
     private
 
-      def helper
-        @helper ||= ManifestHelper.new
-      end
-
       def path
         canvas_builder.new(file_set, resource).path
       end
diff --git a/spec/services/manifest_builder_spec.rb b/spec/services/manifest_builder_spec.rb
index 9eb64e08d2..a4683e202b 100644
--- a/spec/services/manifest_builder_spec.rb
+++ b/spec/services/manifest_builder_spec.rb
@@ -29,6 +29,7 @@
   let(:metadata_adapter) { Valkyrie.config.metadata_adapter }
   let(:query_service) { metadata_adapter.query_service }
   let(:file) { fixture_file_upload('files/example.tif', 'image/tiff') }
+  let(:start_canvas) { nil }
 
   def logical_structure(file_set_id)
     [
@@ -61,7 +62,7 @@ def logical_structure(file_set_id)
       file_set.local_identifier = "p79409x97p"
       metadata_adapter.persister.save(resource: file_set)
       change_set = ScannedResourceChangeSet.new(output)
-      change_set.validate(logical_structure: logical_structure(file_set_id), start_canvas: file_set_id)
+      change_set.validate(logical_structure: logical_structure(file_set_id), start_canvas: start_canvas || file_set_id)
       change_set.sync
       change_set_persister.save(change_set: change_set)
     end
@@ -130,6 +131,15 @@ def logical_structure(file_set_id)
       end
     end
 
+    context "when a start_canvas doesn't exist" do
+      let(:start_canvas) { Valkyrie::ID.new("blablabla") }
+      it "doesn't set a startCanvas" do
+        output = manifest_builder.build
+        first_sequence = output["sequences"][0]
+        expect(first_sequence["startCanvas"]).to be_nil
+      end
+    end
+
     context "when in staging" do
       it "generates cantaloupe links" do
         allow(Rails.env).to receive(:development?).and_return(false)