Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I3573 mini profiler #3584

Merged
merged 2 commits into from
May 26, 2023
Merged

I3573 mini profiler #3584

merged 2 commits into from
May 26, 2023

Conversation

maxkadel
Copy link
Contributor

@maxkadel maxkadel commented May 25, 2023

Connected to #3573
Connected to #3576

Makes it easier to find gems, and know where to put new ones.
@pulbot pulbot temporarily deployed to staging May 25, 2023 19:34 Inactive
@coveralls
Copy link

coveralls commented May 25, 2023

Coverage Status

Coverage: 95.303%. Remained the same when pulling a3b0efb on i3573_mini_profiler into 3bd6b42 on main.

@pulbot pulbot temporarily deployed to staging May 25, 2023 19:56 Inactive
- Add wait to failing stackmap test
@pulbot pulbot temporarily deployed to staging May 26, 2023 14:03 Inactive
@maxkadel maxkadel marked this pull request as ready for review May 26, 2023 14:06
Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @maxkadel ! 🦄

@@ -138,7 +138,6 @@ Metrics/PerceivedComplexity:
Naming/FileName:
Exclude:
- 'Capfile'
- 'Gemfile'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

end

context 'as a non-admin user' do
it 'does not authorize the user' do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this test!

@sandbergja sandbergja merged commit eaea2db into main May 26, 2023
@sandbergja sandbergja deleted the i3573_mini_profiler branch May 26, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants