Add a search builder that allows use of a new request handler #3819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supporting a different Solr RequestHandler Co-authored-by: Anna Headley <hackartisan@users.noreply.github.com> Co-authored-by: Carolyn Cole <carolyncole@users.noreply.github.com> Co-authored-by: Eliot Jordan <eliotjordan@users.noreply.github.com> Co-authored-by: James R. Griffin III <jrgriffiniii@users.noreply.github.com> Co-authored-by: Trey Pendragon <tpendragon@users.noreply.github.com>
jrgriffiniii
force-pushed
the
3808-search-algo
branch
from
20ecd07
to
d9c8466
Compare
sandbergja
reviewed
Nov 8, 2023
| # When adding a new Ranking Algorithm the name will need to be added to this list before it can be utilized | ||
| # For example if you added a cats ranking algorithm, with a CatsSearchBuilder you would add "cats" to this list ["engineering","cats"] | ||
| # This is to make sure the user can not just execute any SearchBuilder in the system | ||
| def allowed_search_algorithms |
There was a problem hiding this comment.
Thanks for adding this check!
…algortihm swapping This shows that the other two features take presidence Co-authored-by: James R. Griffin III <jrgriffiniii@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a querystring parameter, and also behind a feature flipper.
closes #3808
requires pulibrary/pul_solr#375