Upgrading to CircleCI 2.0 #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escowles
reviewed
Jun 25, 2018
.circleci/config.yml
Outdated
| - attach_workspace: | ||
| at: '~/pomegranate' | ||
| - run: sudo apt-get update | ||
| - run: sudo apt-get install libpq-dev libopenjp2-7-dev libmagickwand-dev imagemagick pkg-config |
There was a problem hiding this comment.
I don't see any of these being installed in the v1 config, and they aren't mentioned in the README. Do we want to document additional dependencies that surfaced here?
There was a problem hiding this comment.
These were installed based upon my findings within other projects. I had falsely assumed them to be necessary.
escowles
reviewed
Jun 25, 2018
config/database.yml
Outdated
| database: <%= ENV["POMEGRANATE_DB"] %> | ||
| host: <%= ENV["POMEGRANATE_DB_HOST"] %> | ||
| username: <%= ENV["POMEGRANATE_DB_USERNAME"] %> | ||
| password: <%= ENV["POMEGRANATE_DB_PASSWORD"] %> |
There was a problem hiding this comment.
Are there any changes needed to run the tests locally? Could we fallback on the old defaults?
There was a problem hiding this comment.
My apologies, there were errors in this configuration; I have corrected these, and can now run the tests locally without error.
jrgriffiniii
changed the title
jrgriffiniii
force-pushed
the
issues-385-circle-ci-2
branch
from
0b241bc
to
f4db337
Compare
jrgriffiniii
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #385