Add support for github inline reviews #98

Open
Kostronor opened this Issue Sep 15, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@Kostronor

Github now added it's own review process.

While I didn't have the time to check it out that much I noticed that these reviews are not recognized as approvals/rejections.

They could be uses as an alternative to regex parsing of all comments

@davegaeddert

This comment has been minimized.

Show comment
Hide comment
@davegaeddert

davegaeddert Sep 19, 2016

Member

Thanks for putting this in here. We're working on figuring out exactly how pullapprove might integrate with the new GitHub reviews, but it's going to take a little bit of time as there's no API yet for that new feature. We'll let you know when we know more!

Member

davegaeddert commented Sep 19, 2016

Thanks for putting this in here. We're working on figuring out exactly how pullapprove might integrate with the new GitHub reviews, but it's going to take a little bit of time as there's no API yet for that new feature. We'll let you know when we know more!

@davegaeddert

This comment has been minimized.

Show comment
Hide comment
@davegaeddert

davegaeddert Oct 18, 2016

Member

Looks like there are now webhook events for reviews, no word on an API yet but we'd be able to start with this at least: https://developer.github.com/v3/activity/events/types/#pullrequestreviewevent

Member

davegaeddert commented Oct 18, 2016

Looks like there are now webhook events for reviews, no word on an API yet but we'd be able to start with this at least: https://developer.github.com/v3/activity/events/types/#pullrequestreviewevent

@davegaeddert davegaeddert added enhancement and removed question labels Oct 18, 2016

@davegaeddert

This comment has been minimized.

Show comment
Hide comment
@davegaeddert

davegaeddert Oct 26, 2016

Member

Good news -- PullApprove now reacts to the GitHub webhook events for reviews. Right now they only tell us two things:

  1. When an "approved" review is submitted
  2. When a review "requesting changes" is submitted

Those will then translate into approve/reject in PullApprove.

It does not:

  • look for approve/reject regex's in your review comment
  • put the PullApprove badge on your review comment to indicate a change in PullApprove status (no API to do this yet)
  • support "dismissing" reviews in GitHub (no event for this yet)
  • retroactively translate GitHub reviews into PullApprove approvals (no API to do this yet)

GitHub review integration is enabled by default but can be disabled if need be:

group_defaults:
  github_reviews:
    enabled: false

Deeper integration is on the way as soon as GitHub releases an API!

Member

davegaeddert commented Oct 26, 2016

Good news -- PullApprove now reacts to the GitHub webhook events for reviews. Right now they only tell us two things:

  1. When an "approved" review is submitted
  2. When a review "requesting changes" is submitted

Those will then translate into approve/reject in PullApprove.

It does not:

  • look for approve/reject regex's in your review comment
  • put the PullApprove badge on your review comment to indicate a change in PullApprove status (no API to do this yet)
  • support "dismissing" reviews in GitHub (no event for this yet)
  • retroactively translate GitHub reviews into PullApprove approvals (no API to do this yet)

GitHub review integration is enabled by default but can be disabled if need be:

group_defaults:
  github_reviews:
    enabled: false

Deeper integration is on the way as soon as GitHub releases an API!

@davegaeddert

This comment has been minimized.

Show comment
Hide comment
@davegaeddert

davegaeddert Oct 26, 2016

Member

Forgot to mention that you must be using .pullapprove.yml version: 2.

Member

davegaeddert commented Oct 26, 2016

Forgot to mention that you must be using .pullapprove.yml version: 2.

michael-berlin added a commit to michael-berlin/vitess that referenced this issue Nov 1, 2016

Migrate PullApprove configuration from v1 to v2.
I've followed https://docs.pullapprove.com/migrating-to-v2/ to do so.

We're migrating because v2 is required to recognize GitHub review approvals as LGTM. See pullapprove/support#98 (comment)

michael-berlin added a commit to michael-berlin/vitess that referenced this issue Nov 1, 2016

Migrate PullApprove configuration from v1 to v2.
I've followed https://docs.pullapprove.com/migrating-to-v2/ to do so.

We're migrating because v2 is required to recognize GitHub review approvals as LGTM. See pullapprove/support#98 (comment)

michael-berlin added a commit to michael-berlin/vitess that referenced this issue Nov 1, 2016

Migrate PullApprove configuration from v1 to v2.
I've followed https://docs.pullapprove.com/migrating-to-v2/ to do so.

We're migrating because v2 is required to recognize GitHub review approvals as LGTM. See pullapprove/support#98 (comment)

michael-berlin added a commit to michael-berlin/vitess that referenced this issue Nov 1, 2016

Migrate PullApprove configuration from v1 to v2.
I've followed https://docs.pullapprove.com/migrating-to-v2/ to do so.

We're migrating because v2 is required to recognize GitHub review approvals as LGTM. See pullapprove/support#98 (comment)
@simonbasle

This comment has been minimized.

Show comment
Hide comment

note that a preview API has been announced: https://developer.github.com/changes/2016-12-14-reviews-api/

@wking wking referenced this issue in opencontainers/image-spec Mar 9, 2017

Merged

schema: urls optimization #567

@wking wking referenced this issue in opencontainers/project-template Mar 16, 2017

Merged

.pullapprove.yml: List project maintainers separately #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment