This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Let Pulp 3 dev be installed on non-vagrant hosts #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Successfully tested against a Fedora 26 host. After installing, I logged in and executed the following: systemctl stop firewalld
su - vagrant
source ~/.virtualenvs/pulp/bin/activate
pulp-manager runserver 0.0.0.0:8000I then tested it with Pulp Smash. Only pulpcore is installed, in combination with #115. |
The Pulp 3 dev installer makes use of several local git repositories. For example, `/home/vagrant/devel/pulp` must be present. The current installer enforces this mandate by asserting that those directories are present. Don't require that these directories already exist. Instead, use them as-is if they're present, and clone them if not. This allows Pulp dev environments to be created on non-Vagrant hosts. Beware that there are some nasty issues with the dev installer. For example, the installer assumes that Ansible is connecting to the host as user "vagrant." (This assumption is reasonable when Vagrant is used as the VM management tool, but it's unreasonable for development hosts more generally.) If Ansible connects as, say, root, then files and directories owned by root will be created in `/home/vagrant`. See: https://pulp.plan.io/issues/3318
|
Tested this with my vagrant environment. Pulp works as expected after vagrant up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pulp 3 dev installer makes use of several local git repositories.
For example,
/home/vagrant/devel/pulpmust be present. The currentinstaller enforces this mandate by asserting that those directories are
present.
Don't require that these directories already exist. Instead, use them
as-is if they're present, and clone them if not. This allows Pulp dev
environments to be created on non-Vagrant hosts.
Beware that there are some nasty issues with the dev installer. For
example, the installer assumes that Ansible is connecting to the host as
user "vagrant." (This assumption is reasonable when Vagrant is used as
the VM management tool, but it's unreasonable for development hosts more
generally.) If Ansible connects as, say, root, then files and
directories owned by root will be created in
/home/vagrant.See: https://pulp.plan.io/issues/3318