This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Don't require Python 3.5+ #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change should have no impact on Fedora installs, and is necessary in order to enable RHEL 7 installs. This and #130 are the only PRs remaining before I can submit a PR that will enable support for RHEL 7. Tested against non-Vagrant F26 and F27 VMs. |
|
The original reason for requiring Python 3.5+ was some stuff in pulp_facts.py, which is apparently gone :) |
It's entirely possible to install Pulp 3 on a host for which the `ansible_python_interpreter` is older than Python 3.5. What matters is that Python 3.5+ can be made available. For example, on RHEL 7, the default Python interpreter is Python 2.7, but Python 3.5 can be installed via an SCL, and Pulp can be installed into a virtualenv that uses the SCL Python.
dralley
approved these changes
Mar 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's entirely possible to install Pulp 3 on a host for which the
ansible_python_interpreteris older than Python 3.5. What matters isthat Python 3.5+ can be made available. For example, on
RHEL 7, the default Python interpreter is Python 2.7, but Python 3.5 can
be installed via an SCL, and Pulp can be installed into a virtualenv
that uses the SCL Python.