Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Switch default box type to CentOS #222

Merged
merged 1 commit into from Jul 26, 2019
Merged

Switch default box type to CentOS #222

merged 1 commit into from Jul 26, 2019

Conversation

dralley
Copy link
Contributor

@dralley dralley commented Jul 24, 2019

Modify ansible scripts and bootstrap-ansible.sh accordingly

state: present
name: "{{ pulp_rpm_dependencies }}"

- name: Ensure homedir mode suitable for ssh keys
file: dest=/home/{{ ansible_env.SUDO_USER }} mode=0750
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while (months) since I made these changes but IIRC it was actually complaining or warning about this, it wasn't just an aesthetic formatting change.

@dralley dralley force-pushed the centos branch 7 times, most recently from 3e30850 to d869890 Compare July 24, 2019 22:30
Modify ansible scripts and bootstrap-ansible.sh accordingly
@@ -72,7 +74,7 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
# issue and our use case, the default cpu_mode is overridden.
domain.cpu_mode = "host-passthrough"
domain.graphics_type = "spice"
domain.memory = 3076
domain.memory = 3096
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3072 is the correct value for 3GB exactly. It is 3*1024.

If you want to give the kernel / (virtual) bios some memory so userspace has 3GB, 3096 sounds about right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure my motivation was never that advanced :) I think the centos-fips branch where we first made these patches was from when we provisioned with 2gb and I increased it to a number that sounded right without actually doing the match lol.

Copy link
Member

@dkliban dkliban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR and it works great! Thank you @dralley!

@dralley dralley merged commit acc545c into pulp:2-master Jul 26, 2019
@dralley dralley deleted the centos branch July 26, 2019 18:38
@@ -2,4 +2,4 @@

# minimal bootstrapping before kicking off ansible:
# install only what ansible needs to survive, or doesn't know how to do
sudo dnf -y install python2 python2-dnf libselinux-python
sudo yum -y install python2 python2-yum libselinux-python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python2-yum does not exist.

Yum doesn't have a stable API for things like Ansible. Ansible (as intelligently as possible) wraps around the yum command.

Copy link
Contributor Author

@dralley dralley Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the command never errored out (or had negative effects) so I never noticed. Box seems to work fine anyways, but I'll make the change and push a new commit eventually.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants