Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Provisioning updates for Pulp 3 #37

Merged
merged 1 commit into from Mar 27, 2017
Merged

Provisioning updates for Pulp 3 #37

merged 1 commit into from Mar 27, 2017

Conversation

seandst
Copy link
Contributor

@seandst seandst commented Mar 13, 2017

- Example Vagrantfile updated with changes from pulp 2
- modified the gitignore to ignore different Vagrantfiles and
  all playbook retry files from ansible.
- Playbook updated to use the dev_requirements file intoduced in
  pulp/pulp#2888
@mention-bot
Copy link

@seandst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jeremycline and @mhrivnak to be potential reviewers.

@seandst
Copy link
Contributor Author

seandst commented Mar 27, 2017

In working with the new pulp_file plugin, I've discovered an annoyance with migrations that makes me think we should not make them until we decide the data model is good. I'm not sure if I'll open a separate issue for this, or just roll it up into this "fix 3.0-dev vagrant" omnibus to address this, though.

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. I just ran it also and that worked well too. Thanks @seandst 👍

@bmbouter
Copy link
Member

@seandst regarding the migrations +1 to not committing them until later in the project. Feel free to fix/modify however you see fit.

@seandst
Copy link
Contributor Author

seandst commented Mar 27, 2017

I'm finding a few things that I'd like to fix as part of the process of documenting how plugins should work with platform and be laid out. I think I'll merge this for now, and file/fix issues as appropriate. I think the migrations problem is something I should fix as part of my PRs to stub out the file plugin, since they're required for it to work, and the other issues we can fix in the normal sprint cycle. They're annoying, but not totally breaking.

@seandst seandst merged commit fb57f0c into pulp:3.0-dev Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants