Conversation
4caefdf
to
77900f5
Compare
5b0668e
to
8cd0a13
Compare
|
Docs to go with this change: pulp/pulp#3051 |
ansible/roles/vagrant/files/motd
Outdated
|
|
||
| * You can ssh into your vagrant environment with vagrant ssh, but presumably | ||
| you already know this since you are reading this message :) | ||
| * The 'phelp' alias will list useful functions and what they do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message displays even if phelp isn't aliased.
When I vagrant up the minimal-playbook supplement_bashrc is false and the alias.bashrc is not copied over.
ansible/roles/vagrant/files/motd
Outdated
|
|
||
| * You can ssh into your vagrant environment with vagrant ssh, but presumably | ||
| you already know this since you are reading this message :) | ||
| * The 'phelp' alias will list useful functions and what they do. | ||
|
|
||
| More information can be found at | ||
| https://pulp.readthedocs.org/en/latest/dev-guide/ and you can ask questions in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the link to the 3.0 docs?
| @@ -0,0 +1 @@ | |||
| export DJANGO_SETTINGS_MODULE=pulpcore.app.settings | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe set this as an environment variable inside the common/tasks/main.yml
http://docs.ansible.com/ansible/faq.html#how-can-i-set-the-path-or-any-other-environment-variable-for-a-task-or-entire-playbook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure that the environment keyword only works within Ansible scope. If we want to use Django from the shell this variable is not required because the user can also pass their own location.
| @@ -0,0 +1,23 @@ | |||
| --- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 renamed to example.
ansible/minimal-playbook.yml
Outdated
| become: true | ||
| become_method: sudo | ||
| roles: | ||
| - vagrant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised to see vagrant in the minimal playbook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good refactoring. Makes the devel package much more usable and easier to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!! Thanks @asmacdo.
This work is intended to make our development environment more flexible, simpler to debug, and less coupled to specific tools. Specifically, the dev-playbook should work correctly with and without Vagrant.