Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Separate roles, flatten variables #56

Merged
merged 1 commit into from Jun 19, 2017
Merged

Conversation

asmacdo
Copy link
Contributor

@asmacdo asmacdo commented May 24, 2017

This work is intended to make our development environment more flexible, simpler to debug, and less coupled to specific tools. Specifically, the dev-playbook should work correctly with and without Vagrant.

@asmacdo asmacdo changed the title Separate roles, flatten variables [wip] Separate roles, flatten variables May 30, 2017
@asmacdo asmacdo force-pushed the separate-roles branch 2 times, most recently from 4caefdf to 77900f5 Compare June 9, 2017 18:50
@asmacdo asmacdo force-pushed the separate-roles branch 2 times, most recently from 5b0668e to 8cd0a13 Compare June 12, 2017 13:26
@asmacdo asmacdo changed the title [wip] Separate roles, flatten variables Separate roles, flatten variables Jun 12, 2017
@asmacdo
Copy link
Contributor Author

asmacdo commented Jun 12, 2017

Docs to go with this change: pulp/pulp#3051

@werwty werwty self-assigned this Jun 13, 2017

* You can ssh into your vagrant environment with vagrant ssh, but presumably
you already know this since you are reading this message :)
* The 'phelp' alias will list useful functions and what they do.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message displays even if phelp isn't aliased.
When I vagrant up the minimal-playbook supplement_bashrc is false and the alias.bashrc is not copied over.


* You can ssh into your vagrant environment with vagrant ssh, but presumably
you already know this since you are reading this message :)
* The 'phelp' alias will list useful functions and what they do.

More information can be found at
https://pulp.readthedocs.org/en/latest/dev-guide/ and you can ask questions in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the link to the 3.0 docs?

@@ -0,0 +1 @@
export DJANGO_SETTINGS_MODULE=pulpcore.app.settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure that the environment keyword only works within Ansible scope. If we want to use Django from the shell this variable is not required because the user can also pass their own location.

@@ -0,0 +1,23 @@
---
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 renamed to example.

become: true
become_method: sudo
roles:
- vagrant
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised to see vagrant in the minimal playbook.

Copy link

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good refactoring. Makes the devel package much more usable and easier to understand.

Copy link
Contributor

@werwty werwty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! Thanks @asmacdo.

@asmacdo asmacdo merged commit 63f4a52 into pulp:3.0-dev Jun 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants