Introducing tests against minio #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fao89
force-pushed
the
5962
branch
5 times, most recently
from
3276670
to
1df9e3b
Compare
fao89
force-pushed
the
5962
branch
6 times, most recently
from
a379b5b
to
3e0edf0
Compare
daviddavis
reviewed
Mar 9, 2020
plugin-template
Outdated
| @@ -44,10 +45,24 @@ DEFAULT_SETTINGS = { | |||
| 'pulpcore_pip_version_specifier': None, | |||
| 'pypi_username': None, | |||
| 'stable_branch': None, | |||
| 's3_settings': { | |||
| 'aws_access_key_id': '"AKIAIT2Z5TDYPX3ARJBA"', | |||
There was a problem hiding this comment.
Aren't we hardcoding this value in the test scripts? I'm thinking we should just hardcode all of these s3 settings as well as I doubt plugin writers will need to tweak them.
daviddavis
reviewed
Mar 9, 2020
| {%- for setting, value in pulp_settings.items() -%} {{ setting }}: {{ value }} | ||
| {% endfor -%} | ||
| {% endif -%} | ||
| aws_access_key_id: "AKIAIT2Z5TDYPX3ARJBA" |
There was a problem hiding this comment.
I think these need to be wrapped in a {%- if test_s3 %} no?
There was a problem hiding this comment.
it is not needed as it is inside of if [ "$TEST" = 's3' ]; then
daviddavis
approved these changes
Mar 9, 2020
Required PR: pulp/pulpcore#568 Required PR: pulp/pulp-operator#35 https://pulp.plan.io/issues/5962 closes #5962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/5962
closes #5962