Adds support for publishing docs to pulpproject.org #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/7229 |
fao89
reviewed
Aug 26, 2020
| print("Building the docs") | ||
| docs_directory = os.sep.join([WORKING_DIR, "docs"]) | ||
|
|
||
| make_command = ["make", "PULP_URL=http://pulp", "diagrams", "html"] |
There was a problem hiding this comment.
Not about this PR, but I think we should have make bindings_docs
There was a problem hiding this comment.
yes, we will add that separately.
|
Code LGTM. What about some docs in the README and also a changelog entry? |
dkliban
force-pushed
the
publish-docs-pulpprojectdotorg
branch
2 times, most recently
from
99a2963
to
8540c51
Compare
dkliban
force-pushed
the
publish-docs-pulpprojectdotorg
branch
from
8540c51
to
70baa24
Compare
dkliban
force-pushed
the
publish-docs-pulpprojectdotorg
branch
2 times, most recently
from
e9f3766
to
cd7850b
Compare
dkliban
force-pushed
the
publish-docs-pulpprojectdotorg
branch
from
cd7850b
to
c4a3443
Compare
daviddavis
reviewed
Sep 16, 2020
daviddavis
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #7229
https://pulp.plan.io/issues/7229