Added support for deprecation type to towncrier #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/7421 |
mdellweg
reviewed
Aug 31, 2020
| directory = "deprecation" | ||
| name = "Deprecations" | ||
| showcontent = true | ||
|
|
There was a problem hiding this comment.
Now i am wondering if this file should still be in the "bootstrap" section, because that makes it a mess to update in existing plugins.
There was a problem hiding this comment.
when I created a new type for pulp_installer, it stopped to recognize the old ones, I had to do it:
https://github.com/pulp/pulp_installer/blob/master/pyproject.toml#L36-L39
(Maybe I missed something there, I'm just pointing it out, for us to test this change)
There was a problem hiding this comment.
This question (moving files) does not need to be answered here, obviously.
There was a problem hiding this comment.
@mdellweg it's definitely worth a discussion.
fao89
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7421