Add check-manifest to plugin_template #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fao89
reviewed
Oct 6, 2020
README.md
Outdated
Comment on lines
63
to
65
| check_manifest Runs check-manifest to see if any files that were unintentionally left out | ||
| MANIFEST.in. See https://pypi.org/project/check-manifest/. | ||
|
|
daviddavis
force-pushed
the
issue7656
branch
2 times, most recently
from
057f415
to
800d08e
Compare
|
Attached issue: https://pulp.plan.io/issues/7656 |
daviddavis
force-pushed
the
issue7656
branch
3 times, most recently
from
d435cac
to
ac1aa79
Compare
fixes #7656
mdellweg
reviewed
Oct 8, 2020
| [tool.check-manifest] | ||
| ignore = [ | ||
| ".bumpversion.cfg", | ||
| "CHANGES/**", |
There was a problem hiding this comment.
Is this check run when doing a release? At that point, CHANGES should actually be empty.
There was a problem hiding this comment.
It's run as part of our test suite so it's run against PRs and releases.
It's technically not empty at release time as there's still a .TEMPLATE.rst file in it.
bmbouter
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7656