Upgrade tests #384
Merged
Upgrade tests #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fao89
force-pushed
the
upgrade_tests
branch
2 times, most recently
from
37ec712
to
2b9b4fb
Compare
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
fao89
force-pushed
the
upgrade_tests
branch
3 times, most recently
from
a491fcf
to
45bfc66
Compare
dkliban
reviewed
May 17, 2021
| @@ -17,6 +17,7 @@ from jinja2 import Environment, FileSystemLoader | |||
|
|
|||
| DEFAULT_SETTINGS = { | |||
| 'additional_repos': [], | |||
| 'upgrade_range': [], | |||
There was a problem hiding this comment.
Please add this variable to the README
dkliban
reviewed
May 18, 2021
| echo ::endgroup:: | ||
| echo "TEST=upgrade" >> $GITHUB_ENV | ||
| echo "HTTPIE_CONFIG_DIR=$GITHUB_WORKSPACE/.ci/assets/httpie/" >> $GITHUB_ENV | ||
| {%- for plugin_branch, version in upgrade_range[0].items() %} |
There was a problem hiding this comment.
Why is the index 0 needed here?
There was a problem hiding this comment.
upgrade_range is a list of dicts:
upgrade_range = [
{ "pulpcore_branch": "X.Y", "pulp_file_branch": "X.Y"},
{ "pulpcore_branch": "X.Y - 1", "pulp_file_branch": "X.Y - 1"}
]the keys would repeat, so I took only the first dict keys
https://pulp.plan.io/issues/8776 closes #8776
dkliban
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]