This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Replace ProgressBar with ProgressReport #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goosemania
suggested changes
Sep 19, 2019
| with ProgressBar(message='Migrating {} content to Pulp 3'.format(content_type.upper()), | ||
| total=total_pulp2content) as pb: | ||
| with ProgressReport(message='Migrating {} content to Pulp 3'.format(content_type.upper()), | ||
| code='migrating.content', total=total_pulp2content) as pb: |
There was a problem hiding this comment.
@fabricio-aguiar ,
Could you please include content type into the code since we have migrating.content code already?
e.g. code='migrating.{}.content'.format(content_type) or whichever way you prefer to do string formatting.
ref #5444 https://pulp.plan.io/issues/5444 Required PR: pulp/pulpcore#293 Required PR: pulp/pulpcore-plugin#127 Required PR: pulp/pulp_file#277
goosemania
approved these changes
Sep 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #5444
https://pulp.plan.io/issues/5444
Required PR: pulp/pulpcore#293
Required PR: pulp/pulpcore-plugin#127
Required PR: pulp/pulp_file#277