New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming base fields #31
Conversation
_id to pulp_id _created to pulp_created _last_updated to pulp_last_updated _href to pulp_href closes #5457 https://pulp.plan.io/issues/5457 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
closes #5454 https://pulp.plan.io/issues/5454 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
_id to pulp_id _created to pulp_created _last_updated to pulp_last_updated _href to pulp_href closes #5457 https://pulp.plan.io/issues/5457 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
closes #5454 https://pulp.plan.io/issues/5454 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
closes #5454 https://pulp.plan.io/issues/5454 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
_id to pulp_id _created to pulp_created _last_updated to pulp_last_updated _href to pulp_href closes #5457 https://pulp.plan.io/issues/5457 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
closes #5454 https://pulp.plan.io/issues/5454 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
closes #5454 https://pulp.plan.io/issues/5454 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
_id to pulp_id _created to pulp_created _last_updated to pulp_last_updated _href to pulp_href closes #5457 https://pulp.plan.io/issues/5457 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
closes #5454 https://pulp.plan.io/issues/5454 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
closes #5550 https://pulp.plan.io/issues/5550 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
_id to pulp_id _created to pulp_created _last_updated to pulp_last_updated _href to pulp_href closes #5457 https://pulp.plan.io/issues/5457 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
closes #5454 https://pulp.plan.io/issues/5454 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
closes #5550 https://pulp.plan.io/issues/5550 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I think we need to have Travis updated before it will pass. I'm approving because the code looks right.
|
I need to merge https://github.com/pulp/pulp-certguard/pull/32/files and we should rebase onto it. |
|
@fabricio-aguiar Could you rebase now that #32 is merged? |
67eb868
to
fed597d
Compare
_id to pulp_id _created to pulp_created _last_updated to pulp_last_updated _href to pulp_href ref #5457 https://pulp.plan.io/issues/5457 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulpcore#317
_id to pulp_id _created to pulp_created _last_updated to pulp_last_updated _href to pulp_href closes #5457 https://pulp.plan.io/issues/5457 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
closes #5454 https://pulp.plan.io/issues/5454 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
closes #5550 https://pulp.plan.io/issues/5550 Required PR: pulp/pulp_file#284 Required PR: pulp/pulpcore-plugin#137 Required PR: pulp/pulp-smash#1220 Required PR: pulp/pulp-certguard#31
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href
ref #5457
https://pulp.plan.io/issues/5457
Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulpcore#317