Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming base fields #31

Merged
merged 1 commit into from Oct 9, 2019
Merged

Renaming base fields #31

merged 1 commit into from Oct 9, 2019

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Oct 2, 2019

_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulpcore#317

fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 2, 2019
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

closes #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 2, 2019
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 4, 2019
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

closes #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 4, 2019
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 4, 2019
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 8, 2019
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

closes #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 8, 2019
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 8, 2019
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 8, 2019
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

closes #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 8, 2019
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 8, 2019
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 9, 2019
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

closes #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 9, 2019
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 9, 2019
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I think we need to have Travis updated before it will pass. I'm approving because the code looks right.

@bmbouter
Copy link
Member

bmbouter commented Oct 9, 2019

I need to merge https://github.com/pulp/pulp-certguard/pull/32/files and we should rebase onto it.

@bmbouter
Copy link
Member

bmbouter commented Oct 9, 2019

@fabricio-aguiar Could you rebase now that #32 is merged?

@fao89 fao89 force-pushed the 5457 branch 2 times, most recently from 67eb868 to fed597d Compare October 9, 2019 16:35
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulpcore#317
daviddavis pushed a commit to pulp/pulpcore that referenced this pull request Oct 9, 2019
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

closes #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
daviddavis pushed a commit to pulp/pulpcore that referenced this pull request Oct 9, 2019
daviddavis pushed a commit to pulp/pulpcore that referenced this pull request Oct 9, 2019
@daviddavis daviddavis merged commit 99ad773 into pulp:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants