Pins sphinx to 1.6.5 #468
Closed
Pins sphinx to 1.6.5 #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
approved these changes
Jan 26, 2018
dralley
reviewed
Jan 26, 2018
| @@ -51,7 +51,8 @@ | |||
| # create a virtualenv in which to install packages needed to build docs | |||
| virtualenv -p /usr/bin/python3 --system-site-packages ~/docs_ve | |||
| source ~/docs_ve/bin/activate | |||
| pip3 install celery 'django<2' django-filter djangorestframework==3.6.4 djangorestframework-jwt drf-nested-routers psycopg2 sphinx git+https://github.com/snide/sphinx_rtd_theme.git@abfa98539a2bfc44198a9ca8c2f16efe84cc4d26 pyyaml virtualenv | |||
| pip3 install celery 'django<2' django-filter djangorestframework==3.6.4 | |||
There was a problem hiding this comment.
Why the newline, and will this be problematic?
There was a problem hiding this comment.
In editors that are set to not wrap code, this line of code is hard to read and edit as-is. I suspect a backslash is necessary, though.
dralley
requested changes
Feb 6, 2018
Ichimonji10
reviewed
Feb 6, 2018
| @@ -126,7 +127,8 @@ | |||
| # create a virtualenv in which to install packages needed to build docs | |||
| python3 -m venv --system-site-packages ~/docs_ve | |||
| source ~/docs_ve/bin/activate | |||
| pip3 install celery sphinxcontrib-swaggerdoc 'django<2' django-filter djangorestframework djangorestframework-jwt drf-nested-routers psycopg2 sphinx git+https://github.com/snide/sphinx_rtd_theme.git@abfa98539a2bfc44198a9ca8c2f16efe84cc4d26 pyyaml virtualenv | |||
| pip3 install celery sphinxcontrib-swaggerdoc 'django<2' django-filter | |||
There was a problem hiding this comment.
Please add a backslash here, too.
|
The docs builder issues were fixed via updating the docs. So we do not need to pin sphinx to 1.6.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.