Have PR processor automatically merge PRs #737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
auto-merge-prs
branch
from
fdfb80b
to
e15bcd2
Compare
fao89
approved these changes
Sep 28, 2020
Comment on lines
+116
to
+144
| def merge_pr(pr): | ||
| """Check if a PR is ready for merge and if so, attempt to merge it.""" | ||
| print(f"Checking PR {pr.number} to see if it's mergeable.") | ||
|
|
||
| if pr.draft: | ||
| print(f"PR {pr.number} is a draft, skipping merge.") | ||
| return | ||
|
|
||
| if pr.get_reviews().totalCount < 1: | ||
| # technically not required if branch protection is set up properly since | ||
| # mergeable_state will say "blocking" if there aren't enough reviews | ||
| print(f"PR {pr.number} has not been reviewed, skipping merge.") | ||
| return | ||
|
|
||
| if pr.mergeable_state != "clean": | ||
| print(f"PR {pr.number} has state {pr.mergeable_state}, skipping merge.") | ||
| return | ||
|
|
||
| if any(commit for commit in pr.get_commits() if | ||
| commit.raw_data["commit"]["verification"]["verified"]): | ||
| merge_method = "merge" | ||
| else: | ||
| merge_method = "rebase" | ||
|
|
||
| pr.merge(merge_method=merge_method) | ||
| print(f"Merged PR {pr.number} by {merge_method} method.\n") |
daviddavis
force-pushed
the
auto-merge-prs
branch
from
e15bcd2
to
35b809f
Compare
bmbouter
approved these changes
Oct 13, 2020
ipanova
reviewed
Oct 15, 2020
| return | ||
|
|
||
| if any(commit for commit in pr.get_commits() if | ||
| commit.raw_data["commit"]["verification"]["verified"]): |
|
Closing out due to inactivity. It seems like there are now github actions that can auto-merge as well if we want to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of what you see in the diff is just moving around code. The only new code is in the
merge_prfunction.