Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support click 8 #256

Closed
2 tasks
daviddavis opened this issue May 26, 2021 · 2 comments · Fixed by #277
Closed
2 tasks

Support click 8 #256

daviddavis opened this issue May 26, 2021 · 2 comments · Fixed by #277
Assignees
@mdellweg
Labels
feature request New feature request (template-set)
Milestone
0.10.0

Comments

@daviddavis
Copy link
Contributor

daviddavis commented May 26, 2021 •
edited by mdellweg
Loading

Tasks:

  • click-shell doesn't support click 8
    - [ ] get bash tab completion working
  • mypy linting is hard to impossible to fix for 7 and 8 simultaneously

edit: The shell completion issue is actually: pallets/click#1940
@daviddavis daviddavis added the feature request New feature request (template-set) label May 26, 2021
@daviddavis
Copy link
Contributor Author

Not sure if we can do anything about the last (mypy) bullet item?

@mdellweg mdellweg mentioned this issue May 26, 2021
Open
@mdellweg mdellweg self-assigned this Jun 25, 2021
@mdellweg
Copy link
Member

To fix click shell, we intend to switch to https://github.com/gouttegd/click-shell

mdellweg added a commit to mdellweg/pulp-cli that referenced this issue Jun 25, 2021
@mdellweg
Update to click 8
cc0795e 
This will use a compatible fork of click-shell for the time being.
Also update mypy.

fixes pulp#256
@mdellweg mdellweg mentioned this issue Jun 25, 2021
Merged
mdellweg added a commit to mdellweg/pulp-cli that referenced this issue Jun 25, 2021
@mdellweg
Update to click 8
64e4544 
This will use a compatible fork of click-shell for the time being.
Also update mypy.

fixes pulp#256
@mdellweg mdellweg added this to the 0.10.0 milestone Jun 25, 2021
mdellweg added a commit that referenced this issue Jun 25, 2021
@mdellweg
Update to click 8
667498c 
This will use a compatible fork of click-shell for the time being.
Also update mypy.

fixes #256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdellweg mdellweg

Labels
feature request New feature request (template-set)
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Update to click 8 mdellweg/pulp-cli
2 participants
@daviddavis @mdellweg