Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mkdocs #247

Merged
merged 3 commits into from Jun 8, 2021
Merged

Adding mkdocs #247

merged 3 commits into from Jun 8, 2021

Conversation

daviddavis
Copy link
Contributor

Here's an option to build and publish our docs. Feedback welcome. If this looks good, I can work on a github action workflow to publish our docs to docs.pulpproject.org.

Also, one thing I need to figure out is how to get the links working.

@daviddavis daviddavis force-pushed the mkdocs branch 3 times, most recently from 572d03a to 3377747 Compare May 19, 2021 13:04
@fao89
Copy link
Member

fao89 commented May 21, 2021

we use mkdocs on pulp-installer and pulp-operator, which links are not working?
Here is how readthedocs handle it: https://readthedocs.org/projects/pulp-installer/builds/13807367/

@daviddavis
Copy link
Contributor Author

I'm currently symlinking the README.md at docs/index.md and all the relative links in README.md to places like docs/install.md don't work.

I think I should maybe break up README.md into files like contributing.md and create an actual docs/index.md instead of symlinking the README at docs/index.md.

@fao89
Copy link
Member

fao89 commented May 21, 2021

I'm currently symlinking the README.md at docs/index.md and all the relative links in README.md to places like docs/install.md don't work.

I think I should maybe break up README.md into files like contributing.md and create an actual docs/index.md instead of symlinking the README at docs/index.md.

we did something similar on the installer on the installer, all roles are symlinked, here is an example of pulp_all_services Readme.md referring to pulp_services:

- [pulp_services](../pulp_services/): A role to install & configure Pulp 3's

@daviddavis
Copy link
Contributor Author

@pulp/cli I fixed the links. Please test this out and let me know what you think.

To look at the docs, check out this PR and run make servedocs.

* Redirecting from `http` to `https`, as done by a typical Pulp installation,
does not work properly with `POST` and `PUT` requests.
Please use `https://` in the base url.
Note that the attempt to use `http` leaks sensitive data over an unencrypted connection.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I dropped this. I don't think it's an issue anymore since we don't follow redirects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what happens now, if you try to use the wrong schema?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You get a connection error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ That's if there's no redirect.

If there's a redirect, then users receive this error

@mdellweg
Copy link
Member

I like it! Maybe we do not want to put the releaseing guide out there...

@daviddavis
Copy link
Contributor Author

@pulp/cli it looks like both pulp_installer and pulp-operator are using mkdocs as well but they just publish to https://readthedocs.org/. I could set that up and it would be a lot less work than using docs.pulpproject.org. However, I feel like the latter is a better location. Thoughts?

@ggainey
Copy link
Contributor

ggainey commented Jun 2, 2021

@pulp/cli it looks like both pulp_installer and pulp-operator are using mkdocs as well but they just publish to https://readthedocs.org/. I could set that up and it would be a lot less work than using docs.pulpproject.org. However, I feel like the latter is a better location. Thoughts?

We're trying to deprecate/remove all readthedocs and consolidate on docs.pulpproject, yeah? I'd like everything to be in one place.

David Davis added 2 commits June 4, 2021 13:48
[noissue]
[noissue]
@daviddavis daviddavis force-pushed the mkdocs branch 2 times, most recently from ef407e7 to 3ad554b Compare June 4, 2021 17:49
@daviddavis
Copy link
Contributor Author

Ok, I updated the release workflow. I manually ran the publish docs script as well:

https://docs.pulpproject.org/pulp_cli/

Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo and a suggestion.
Great piece of work!

docs/index.md Outdated Show resolved Hide resolved
docs/releasing.md Outdated Show resolved Hide resolved
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we should merge this soon, to make the "edit on GH" banner work.
Hopefully it will lead to further improvements of the docs.

@daviddavis daviddavis merged commit 2a16b5d into pulp:develop Jun 8, 2021
@mdellweg mdellweg added this to the 0.10.0 milestone Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants