New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding mkdocs #247
Adding mkdocs #247
Conversation
572d03a
to
3377747
Compare
|
we use mkdocs on pulp-installer and pulp-operator, which links are not working? |
|
I'm currently symlinking the README.md at I think I should maybe break up README.md into files like |
we did something similar on the installer on the installer, all roles are symlinked, here is an example of pulp_all_services Readme.md referring to pulp_services: |
|
@pulp/cli I fixed the links. Please test this out and let me know what you think. To look at the docs, check out this PR and run |
| * Redirecting from `http` to `https`, as done by a typical Pulp installation, | ||
| does not work properly with `POST` and `PUT` requests. | ||
| Please use `https://` in the base url. | ||
| Note that the attempt to use `http` leaks sensitive data over an unencrypted connection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I dropped this. I don't think it's an issue anymore since we don't follow redirects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what happens now, if you try to use the wrong schema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You get a connection error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ That's if there's no redirect.
If there's a redirect, then users receive this error
|
I like it! Maybe we do not want to put the releaseing guide out there... |
|
@pulp/cli it looks like both pulp_installer and pulp-operator are using mkdocs as well but they just publish to https://readthedocs.org/. I could set that up and it would be a lot less work than using docs.pulpproject.org. However, I feel like the latter is a better location. Thoughts? |
We're trying to deprecate/remove all readthedocs and consolidate on docs.pulpproject, yeah? I'd like everything to be in one place. |
[noissue]
[noissue]
ef407e7
to
3ad554b
Compare
|
Ok, I updated the release workflow. I manually ran the publish docs script as well: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A typo and a suggestion.
Great piece of work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we should merge this soon, to make the "edit on GH" banner work.
Hopefully it will lead to further improvements of the docs.
Here's an option to build and publish our docs. Feedback welcome. If this looks good, I can work on a github action workflow to publish our docs to docs.pulpproject.org.
Also, one thing I need to figure out is how to get the links working.