Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RBAC content guard support #353

Merged
merged 1 commit into from Sep 29, 2021
Merged

Conversation

gerrod3
Copy link
Contributor

@gerrod3 gerrod3 commented Aug 30, 2021

fixes: #352
Requires: pulp/pulpcore#1590

@mdellweg
Copy link
Member

About the status code: We have a fallback for the other way around:
https://github.com/pulp/pulp-cli/blob/develop/pulpcore/cli/common/openapi.py#L224

@mdellweg mdellweg added this to the 0.12.0 milestone Aug 31, 2021

# shellcheck source=tests/scripts/config.source
. "$(dirname "$(dirname "$(realpath "$0")")")"/config.source

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a pulp debug has_plugin ... line here.

CHANGES/352.feature Outdated Show resolved Hide resolved
pulpcore/cli/core/context.py Outdated Show resolved Hide resolved
tests/scripts/pulpcore/test_content_guards.sh Outdated Show resolved Hide resolved
pulpcore/cli/core/content_guard.py Outdated Show resolved Hide resolved
@gerrod3 gerrod3 force-pushed the content-guards branch 2 times, most recently from 72facb5 to 245a045 Compare September 23, 2021 14:18
pulpcore/cli/core/content_guard.py Outdated Show resolved Hide resolved
pulpcore/cli/core/content_guard.py Outdated Show resolved Hide resolved
pulpcore/cli/core/content_guard.py Outdated Show resolved Hide resolved
pulpcore/cli/core/content_guard.py Outdated Show resolved Hide resolved
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is it.

@ggainey ggainey merged commit 18aab73 into pulp:develop Sep 29, 2021
@gerrod3 gerrod3 deleted the content-guards branch September 29, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RBAC Content Guard support
3 participants