New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use multi stage dockerfile #136
Conversation
|
@daviddavis I believe this is not clean enough, but i wanted to show you how i think a multi stage build can help to generate that container. |
5e3c5ef
to
9f3990c
Compare
|
This looks great. Why do you say it's not clean enough? |
|
I only copied the apt repo fixture script over from |
|
Also for just serving the stuff, there is probably a better container with nginx preinstalled available. |
|
If you want to do the steps you outlined, I'd be happy to merge this. Also, I think we could probably use the nginx image from docker hub. |
|
Is using this container properly tested? I am not entirely sure, the second copy instruction does not overwrite the result of the first. But i marked the PR as ready, as i fixed the linting. And using the nginx container should be another PR. |
|
My experiment with buildah shows, that the directories are merged. ✔️ |
|
I tested this out locally but I'm seeing the fixtures now in /usr/share/nginx/html/ instead of /usr/share/nginx/html/fixtures/. Are you seeing the same thing? |
|
I added a small test that might help you to verify the container: |
Haven't checked that... |
No description provided.