Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multi stage dockerfile #136

Merged
merged 1 commit into from Feb 5, 2020
Merged

Use multi stage dockerfile #136

merged 1 commit into from Feb 5, 2020

Conversation

mdellweg
Copy link
Member

No description provided.

@mdellweg
Copy link
Member Author

@daviddavis I believe this is not clean enough, but i wanted to show you how i think a multi stage build can help to generate that container.

@mdellweg mdellweg force-pushed the multi_stage branch 2 times, most recently from 5e3c5ef to 9f3990c Compare January 28, 2020 14:25
@daviddavis
Copy link

This looks great. Why do you say it's not clean enough?

@mdellweg
Copy link
Member Author

I only copied the apt repo fixture script over from pulp_deb. It didn't lint by then, also it does not yet use the Makefile.

@mdellweg
Copy link
Member Author

Also for just serving the stuff, there is probably a better container with nginx preinstalled available.

@daviddavis
Copy link

If you want to do the steps you outlined, I'd be happy to merge this. Also, I think we could probably use the nginx image from docker hub.

@mdellweg mdellweg marked this pull request as ready for review January 30, 2020 09:34
@mdellweg
Copy link
Member Author

Is using this container properly tested? I am not entirely sure, the second copy instruction does not overwrite the result of the first. But i marked the PR as ready, as i fixed the linting. And using the nginx container should be another PR.

@mdellweg
Copy link
Member Author

My experiment with buildah shows, that the directories are merged. ✔️

@daviddavis
Copy link

I tested this out locally but I'm seeing the fixtures now in /usr/share/nginx/html/ instead of /usr/share/nginx/html/fixtures/. Are you seeing the same thing?

@daviddavis
Copy link

I added a small test that might help you to verify the container:

#141

@mdellweg
Copy link
Member Author

mdellweg commented Feb 5, 2020

I tested this out locally but I'm seeing the fixtures now in /usr/share/nginx/html/ instead of /usr/share/nginx/html/fixtures/. Are you seeing the same thing?

Haven't checked that...

@daviddavis daviddavis merged commit ceb0714 into pulp:master Feb 5, 2020
@mdellweg mdellweg deleted the multi_stage branch February 6, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants