Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in ostree, puppet, and docker fixtures #175

Merged
merged 1 commit into from Jul 2, 2020

Conversation

daviddavis
Copy link

@daviddavis daviddavis commented Jul 1, 2020

The puppet fixture script was disabled a long time ago. We should look
into maybe re-enabling it.

The docker asset would be hard to generate in a container because it'd
require running docker inside docker.

@daviddavis daviddavis marked this pull request as draft July 1, 2020 20:47
@daviddavis daviddavis force-pushed the add-missing-fixtures branch 3 times, most recently from 5049b92 to 69cab5a Compare July 1, 2020 21:13
@daviddavis daviddavis marked this pull request as ready for review July 1, 2020 21:14
@daviddavis daviddavis force-pushed the add-missing-fixtures branch 2 times, most recently from 05c5f68 to f57d626 Compare July 1, 2020 21:30
The puppet fixture script was disabled a long time ago. We should look
into maybe re-enabling it.

The docker asset would be hard to generate in a container because it'd
require running docker inside docker.
@mdellweg
Copy link
Member

mdellweg commented Jul 2, 2020

You know there is the dind container? But the question is, what do we want to generate as container fixtures?
If this is what was found at the old address, i think we are safe to merge it as is.

@daviddavis
Copy link
Author

@mdellweg thanks I did not know there was a dind container. Here's what the docker fixture is doing right now:

# Create output_dir and generate fixture data.
mkdir "${output_dir}"
docker pull "$image_name"
docker save "$image_name" > "${output_dir}/${image_name}.tar"

@daviddavis daviddavis merged commit 4951c0c into pulp:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants