Gh workflow #5
Merged
Gh workflow #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
fao89
reviewed
Jun 9, 2020
fao89
reviewed
Jun 9, 2020
fao89
reviewed
Jun 9, 2020
daviddavis
approved these changes
Jun 10, 2020
|
@daviddavis I have another thing to try. So it's not quite ready. |
mdellweg
force-pushed
the
gh_workflow
branch
5 times, most recently
from
219be57
to
2817ccf
Compare
mdellweg
commented
Jun 10, 2020
| description: "Build (TODO: and test) pulp container images" | ||
| runs: | ||
| using: "docker" | ||
| image: "Dockerfile" |
There was a problem hiding this comment.
@fao89 @daviddavis
As much as it was worth to see how actions work, i'm not sure if calling a common scripts in both workflows were the more pragmatic way. WDYT?
There was a problem hiding this comment.
+1 script sounds good, makes it more CI agnostic
There was a problem hiding this comment.
I didn't add the scripts for the two lines we have atm. But the ticket says we are going to do tests also.
daviddavis
reviewed
Jun 10, 2020
Co-authored-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> fixes #6728 https://pulp.plan.io/issues/6728
[noissue] Co-authored-by: David Davis <daviddavis@users.noreply.github.com>
fao89
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.