Updating travis #31
Updating travis #31
Conversation
[noissue]
| popd | ||
| fi | ||
|
|
||
| pip install -e ./pulpcore[postgres] | ||
| sed -i "s/pulp:80/localhost:24817/g" ./pulpcore/.travis/test_bindings.rb |
There was a problem hiding this comment.
I can see immediately where this comes from (my bad).
But should we not strive for consistency here, and start the same ci-container as used in pulpcore?
Or since we only want to test the bindings-generation, we could use the ready to use container from https://pulp.plan.io/issues/6205.
There was a problem hiding this comment.
I'm not sure, for one side I believe it will make CI slower, for the other side we will have consistency and we rarely touch this repo
There was a problem hiding this comment.
And we'd have more incentive to make that other method faster...
But that's probably not the best reason to do it.
We could defer that question into a new issue and say: This here is fixing the CI today, so take it.
[noissue]