Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide image pull policy or node affinity for deployment #119

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

chambridge
Copy link
Contributor

  • Update CRD to allow for pull policy and node affinity
  • Update deployments for pull policy and node affinity

[noissue]

This work allows an user to select Always as a pull policy to obtain the latest container image on pod deployment (meant to enable testing more easily).

The node affinity capability allows a user to specify a node of the deployments to run on. This could allow users to target nodes with specific disk storage capabilities or specify node labels like infra nodes for subscription related reasons down stream.

* Update CRD to allow for pull policy and node affinity
* Update deployments for pull policy and node affinity

[noissue]
@chambridge chambridge marked this pull request as ready for review April 26, 2021 21:00
Copy link
Member

@fao89 fao89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pulpbot
Copy link
Member

pulpbot commented Apr 26, 2021

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@chambridge chambridge merged commit f82a9c8 into pulp:main Apr 26, 2021
@chambridge chambridge deleted the pull-policy-and-node-affinity branch April 26, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants