Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for pulp_settings #35

Merged
merged 1 commit into from Mar 6, 2020
Merged

Workaround for pulp_settings #35

merged 1 commit into from Mar 6, 2020

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Mar 5, 2020

fao89 added a commit to fao89/pulpcore that referenced this pull request Mar 6, 2020
fao89 added a commit to fao89/plugin_template that referenced this pull request Mar 6, 2020
@fao89 fao89 changed the title Custom filter for S3 vars Workaround for pulp_settings Mar 6, 2020
@fao89 fao89 requested review from mikedep333 and dkliban March 6, 2020 14:08
fao89 added a commit to fao89/pulp_file that referenced this pull request Mar 6, 2020
fao89 added a commit to fao89/pulp_rpm that referenced this pull request Mar 6, 2020
Copy link
Member

@mikedep333 mikedep333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Wow, this is such an elegant solution. Where did you find it?

@fao89
Copy link
Member Author

fao89 commented Mar 6, 2020

Wow, this is such an elegant solution. Where did you find it?

got it from here:
operator-framework/operator-sdk#1770 (comment)
I searched for the name on github and found his project:
https://github.com/TristanCacqueray/dhall-zuul/blob/master/operator/roles/zuul/defaults/main.yaml

@fao89 fao89 merged commit b34a30d into pulp:master Mar 6, 2020
fao89 added a commit to fao89/plugin_template that referenced this pull request Mar 9, 2020
fao89 added a commit to fao89/plugin_template that referenced this pull request Mar 9, 2020
fao89 added a commit to fao89/plugin_template that referenced this pull request Mar 9, 2020
fao89 added a commit to fao89/pulpcore that referenced this pull request Mar 10, 2020
fao89 added a commit to fao89/pulp_file that referenced this pull request Mar 10, 2020
fao89 added a commit to fao89/pulp_rpm that referenced this pull request Mar 10, 2020
fao89 added a commit to fao89/pulpcore that referenced this pull request Mar 10, 2020
daviddavis pushed a commit to pulp/pulp_file that referenced this pull request Mar 10, 2020
daviddavis pushed a commit to pulp/pulp_ansible that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants