Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding docs for roles #45

Merged
merged 1 commit into from Jul 15, 2020
Merged

Adding docs for roles #45

merged 1 commit into from Jul 15, 2020

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Jul 6, 2020

Documenting the roles

@fao89
Copy link
Member Author

fao89 commented Jul 6, 2020

@mikedep333 I'm wondering: should we do the pulp_common logic here?

@pulpbot
Copy link
Member

pulpbot commented Jul 6, 2020

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@fao89 fao89 marked this pull request as ready for review July 7, 2020 18:14
@fao89 fao89 requested a review from mikedep333 July 8, 2020 20:12
mikedep333
mikedep333 approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@mikedep333 mikedep333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this was a lot of work. Thank you!

@fao89 fao89 merged commit 017a79d into pulp:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedep333 mikedep333 mikedep333 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fao89 @pulpbot @mikedep333