This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Update the dev-setup guide + split up requirements #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the new requirements files aren't currently managed by the dev playbook. https://github.com/pulp/devel/blob/3.0-dev/ansible/library/pulp_facts.py#L49-L54 needs to be updated to use them once they're merged. |
Also added some minor tweaks to the dev env: - Ignore migrations with gitignore - Alow setting the admin password with manage.py
seandst
added a commit
to seandst/devel
that referenced
this pull request
Mar 13, 2017
- Example Vagrantfile updated with changes from pulp 2 - modified the gitignore to ignore different Vagrantfiles and all playbook retry files from ansible. - Playbook updated to use the dev_requirements file intoduced in pulp/pulp#2888
|
This should again be ready for review. pulp/devel#37 is required to have support for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the rest of the work for https://pulp.plan.io/issues/2413, where I update the dev-setup guide to line up with the changes to our vagrantfile/ansible playbook, and split up pulp's requirements from stuff that's just "nice to have" in development.
The new requirements files aren't yet known to the ansible dev role, but that's a trivial change the the pulp_facts module once this gets merged.
https://pulp.plan.io/issues/2413
re #2413