Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Fixes #2776: Don't check for active works in dry-run #3037

Merged
merged 1 commit into from May 30, 2017

Conversation

ehelms
Copy link
Contributor

@ehelms ehelms commented May 29, 2017

No description provided.

@mention-bot
Copy link

@ehelms, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mhrivnak, @werwty and @asmacdo to be potential reviewers.

@pulpbot
Copy link
Member

pulpbot commented May 29, 2017

Can one of the admins verify this patch?

1 similar comment
@pulpbot
Copy link
Member

pulpbot commented May 29, 2017

Can one of the admins verify this patch?

@werwty
Copy link
Contributor

werwty commented May 30, 2017

@ehelms Since this is a bugfix could you rebase this PR onto the 2.13-dev branch?
The code looks good, but could you update the commit message to include closes #2776 so redmine can associate it correctly.

@werwty werwty self-assigned this May 30, 2017
@ehelms
Copy link
Contributor Author

ehelms commented May 30, 2017

@werwty Sorry, I don't exactly follow the request. You are wanting me to?

  1. Put my commit onto the 2.13-dev branch
  2. Re-open my PR against the 2.13-branch

Also confused about the commit message change request. The document you linked to includes using the format I used here.

@werwty
Copy link
Contributor

werwty commented May 30, 2017

Github allows you to change the target of the pull request . This PR should target 2.13-dev.

I've always put the redmine reference in a separate line than the rest of the commit message. But looking at the docs, the way you have it should be fine 😳 So please disregard that request and carry on

@ehelms ehelms changed the base branch from master to 2.13-dev May 30, 2017 19:12
@ehelms
Copy link
Contributor Author

ehelms commented May 30, 2017

@werwty Rebased and PR updated to point at 2.13-dev branch.

Copy link
Contributor

@werwty werwty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehelms Thanks very much!

@werwty werwty merged commit b9fa19d into pulp:2.13-dev May 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants