This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Fixing bare exceptions in Status view #3084

Merged

daviddavis merged 1 commit into pulp:3.0-dev from daviddavis:test-pep8speaks

Jul 17, 2017

Contributor

daviddavis commented Jul 13, 2017 •

edited

pep8speaks throws E722 for bare exceptions. From the Python docs:

Because except: catches all exceptions, including SystemExit, KeyboardInterrupt, and GeneratorExit (which is not an error and should not normally be caught by user code), using a bare except: is almost never a good idea. In situations where you need to catch all “normal” errors, such as in a framework that runs callbacks, you can catch the base class for all normal exceptions, Exception.

pep8speaks commented Jul 13, 2017 •

edited

Hello @daviddavis! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on July 13, 2017 at 17:36 Hours UTC


          Fixing bare exceptions per E722

5c32162

daviddavis changed the title ~~Test~~ Fixing bare exceptions in Status view

daviddavis added the 3.0 label

asmacdo approved these changes

View reviewed changes

daviddavis merged commit 17ed0c1 into pulp:3.0-dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.