This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Start using pip to install pulp in travis builds #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the fact that using setup.py for installation is no longer suggested practice in the python community. We start using `pip install -e .` instead of `python setup.py develop`.
|
@BrnoPCmaniak, thanks for your PR! By analyzing the history of the files in this pull request, we identified @daviddavis, @werwty and @goosemania to be potential reviewers. |
werwty
approved these changes
Aug 2, 2017
There was a problem hiding this comment.
LGTM. Our current vagrant environment already uses pip install -e. But some the jjb configurations need to be updated too.
https://github.com/pulp/pulp_packaging/blob/master/ci/jjb/jobs/unittests.yaml#L142
https://github.com/pulp/pulp_packaging/blob/master/ci/docs-builder.py#L66
fdobrovolny
added a commit
to fdobrovolny/pulp_packaging
that referenced
this pull request
Sep 11, 2017
fdobrovolny
added a commit
to fdobrovolny/pulp_packaging
that referenced
this pull request
Sep 11, 2017
fdobrovolny
added a commit
to fdobrovolny/pulp_packaging
that referenced
this pull request
Sep 11, 2017
preethit
pushed a commit
to preethit/pulp_packaging
that referenced
this pull request
Nov 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that using setup.py for installation is no longer
suggested practice in the python community. We start using
pip install -e .instead ofpython setup.py develop.