Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Moving platform/ to pulpcore/ #3217

Merged
merged 1 commit into from Nov 13, 2017
Merged

Moving platform/ to pulpcore/ #3217

merged 1 commit into from Nov 13, 2017

Conversation

daviddavis
Copy link
Contributor

@daviddavis daviddavis commented Nov 8, 2017 •
edited

DO NOT MERGED UNTIL 2017-11-13.

fixes #3089
https://pulp.plan.io/issues/3089

bmbouter
bmbouter suggested changes Nov 9, 2017
View reviewed changes
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks right, but the source install docs also need an update. I think the install commands rely on 'platform' as a dir. I can LGTM after another push, just let me know. Thanks for this!

@daviddavis
Copy link
Contributor Author

@bmbouter good catch. Just pushed fix.

bmbouter
bmbouter approved these changes Nov 9, 2017
View reviewed changes
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daviddavis ! This all looks correct.

@dralley dralley added the 3.0 label Nov 10, 2017
@daviddavis daviddavis merged commit 74bf37e into pulp:3.0-dev Nov 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmbouter bmbouter bmbouter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@daviddavis @bmbouter @dralley