This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Problem: repository URI is mutable #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkliban
force-pushed
the
repository-uri
branch
2 times, most recently
from
4b7f4fd
to
0d8d6a2
Compare
goosemania
reviewed
Nov 10, 2017
| @@ -23,7 +23,7 @@ class HrefWritableRepositoryRelatedField(serializers.HyperlinkedRelatedField): | |||
| read_only should passed as a kwarg to this field. | |||
| """ | |||
| view_name = 'repositories-detail' | |||
| lookup_field = 'name' | |||
| lookup_field = 'pk' | |||
There was a problem hiding this comment.
Do you need to specify pk as a lookup_field explicitly? I think it's a default.
There was a problem hiding this comment.
I believe you are correct. I'll test without it and see if it still works.
There was a problem hiding this comment.
removing the lookup_field seems to work. however, i am not sure what other places in this PR could use a similar change.
dkliban
force-pushed
the
repository-uri
branch
from
0d8d6a2
to
5df14d3
Compare
goosemania
approved these changes
Nov 10, 2017
There was a problem hiding this comment.
Thanks, @dkliban !
Changes look good to me. Please, make sure team is on board with this change before merging it.
Solution: use repository id in the URL instead of name This patch switches repository URI from /api/v3/repositories/<name>/ to /api/v3/repositories/<pk>/. closes pulp#3101 https://pulp.plan.io/issues/3101
dkliban
force-pushed
the
repository-uri
branch
from
5df14d3
to
da25c23
Compare
daviddavis
pushed a commit
that referenced
this pull request
Jan 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: use repository id in the URL instead of name
This patch switches repository URI from
/api/v3/repositories/<name>/to/api/v3/repositories/<pk>/.closes #3101
https://pulp.plan.io/issues/3101