This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Move nested urls to flat structure #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks good, but I haven't run any of it. @asmacdo do you know why the docs builder failed? |
|
@bmbouter, I'm not sure, but I am testing my guess by adding |
asmacdo
force-pushed
the
flatten-urls-3160
branch
from
ab6ea66
to
bd760d0
Compare
|
|
|
Hello @asmacdo! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on December 06, 2017 at 17:59 Hours UTC |
werwty
reviewed
Dec 5, 2017
pulpcore/pulpcore/app/settings.py
Outdated
| @@ -114,7 +114,7 @@ | |||
| 'DEFAULT_FILTER_BACKENDS': ('django_filters.rest_framework.DjangoFilterBackend',), | |||
| 'DEFAULT_PAGINATION_CLASS': 'pulpcore.app.pagination.UUIDPagination', | |||
| 'PAGE_SIZE': 100, | |||
| 'DEFAULT_PERMISSION_CLASSES': ('rest_framework.permissions.IsAuthenticated',), | |||
There was a problem hiding this comment.
Don't forget to uncomment :)
asmacdo
force-pushed
the
flatten-urls-3160
branch
from
f80dee7
to
aa094ae
Compare
asmacdo
force-pushed
the
flatten-urls-3160
branch
from
aa094ae
to
cbba0e4
Compare
|
Nice work, @asmacdo! LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://pulp.plan.io/issues/3160