This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Fix broken link to protected-branches.py #3252
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
dparalen
added a commit
to dparalen/pulp
that referenced
this pull request
Jan 4, 2018
dparalen
commented
Jan 4, 2018
| @@ -43,7 +43,7 @@ on GitHub. The basic protection that disallows force-push and deletion is the | |||
| only option that should be enabled. There should be no restrictions on required | |||
| status checks or who can push. There is a script at | |||
| `devel/scripts/protected-branches.py | |||
| <https://github.com/pulp/devel/tree/master/scripts/protected-branches.py>`_ | |||
| <https://github.com/pulp/devel/blob/master/scripts/protect-branches.py>`_ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tree--blob change might not be necessary, though https://github.com/tree/devel/blob/master/scripts/protect-branches.py auto-redirects to https://github.com/pulp/devel/blob/master/scripts/protect-branches.py
dparalen
added a commit
to dparalen/pulp
that referenced
this pull request
Jan 4, 2018
closes pulp#3245 [Issue 3245](https://pulp.plan.io/issues/3245)
goosemania
approved these changes
Jan 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dparalen :)
|
Thanks for the review, @goosemania! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3252
https://pulp.plan.io/issues/3245