This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Move sync dispatch to plugin API #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @asmacdo! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on January 11, 2018 at 17:19 Hours UTC |
|
LGTM |
asmacdo
force-pushed
the
3074-tasking-plugin-API
branch
3 times, most recently
from
6f3dcb4
to
434fa3f
Compare
Modifies the plugin API, moving responsibility for sync from parent classes to the plugins. closes pulp#3074 https://pulp.plan.io/issues/3074
This is done in a separate commit because it removes items from the plugin API.
asmacdo
force-pushed
the
3074-tasking-plugin-API
branch
from
434fa3f
to
47426fd
Compare
dkliban
suggested changes
Jan 11, 2018
asmacdo
force-pushed
the
3074-tasking-plugin-API
branch
from
0183d8d
to
d839f9e
Compare
dkliban
approved these changes
Jan 11, 2018
daviddavis
approved these changes
Jan 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the plugin API, moving responsibility for sync from
parent classes to the plugins.
closes #3074
https://pulp.plan.io/issues/3074