This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Prevent duplicate content #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jortel
reviewed
Feb 12, 2018
| association.save() | ||
|
|
||
| if self.content_exists(content): | ||
| raise DuplicateContentException(content, self.repository) |
There was a problem hiding this comment.
Do we really want to raise an exception here? Perhaps add_content() should be idempotent.
jortel
reviewed
Feb 12, 2018
| @@ -395,6 +407,9 @@ def remove_content(self, content): | |||
| if self.complete: | |||
| raise ResourceImmutableError(self) | |||
|
|
|||
| if not self.content_exists(content): | |||
There was a problem hiding this comment.
Do we really want to raise an exception here? Perhaps remove_content() should be idempotent.
Prevent users/plugins from adding content to a repo version if that content would otherwise already exist for that repo version. closes #3304 https://pulp.plan.io/issues/3304
|
@jortel updated the PR based on your feedback. |
|
ok test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent users/plugins from adding content to a repo version if that content would otherwise already exist for that repo version.
Added validation to the viewset so we don't kick off a task and a nice user error gets return if the content addition/removal isn't allowed. Also added validation to the model mostly for the benefit of plugins who might call these methods directly.
closes #3304
https://pulp.plan.io/issues/3304