This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Fields: created & last_updated moved to Model. #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dparalen
suggested changes
Feb 13, 2018
pulpcore/pulpcore/app/models/base.py
Outdated
| @@ -11,7 +11,9 @@ class Model(models.Model): | |||
| behavior. | |||
|
|
|||
| Fields: | |||
| id: UUID ID Primary Key Field | |||
| id (models.UUIDField): UUID ID Primary Key Field | |||
| create (models.DateTimeField): Created timestamp UTC. | |||
| @@ -11,7 +11,9 @@ class Model(models.Model): | |||
| behavior. | |||
|
|
|||
| Fields: | |||
| id: UUID ID Primary Key Field | |||
| id (models.UUIDField): UUID ID Primary Key Field | |||
| @@ -271,7 +266,7 @@ def content(self): | |||
| >>> repository_version = ... | |||
| >>> | |||
| >>> for content in repository_version.content: | |||
| >>> content = content.case() # optional downcast. | |||
| >>> content = content.cast() # optional downcast. | |||
| @@ -20,10 +22,9 @@ class Model(models.Model): | |||
| * https://www.postgresql.org/docs/current/static/datatype-uuid.html | |||
|
|
|||
| """ | |||
| # ...we have zero interest in using a mongo-specific datatype (ObjectId) as | |||
jortel
changed the title
dkliban
approved these changes
Feb 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://pulp.plan.io/issues/3337, the FileContent needed to be ordered by a
createdfield. This seemed generally useful for other plugins for the same reason. Then, considered that acreatedtimestamp would be useful on most models. So, why not add it toModel. Along the same line of thinking, why not addlast_updatedwhile we're at it. Should be generally useful for filtering/search and troubleshooting.There are some concerns within the django community regarding auto_now and auto_now_add but I suggest we make this change independently of that. We should be revisited and fix on all models as needed.